Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wishbone.bus: add Arbiter. #3

Closed
nmigen-issue-migration opened this issue Jan 22, 2020 · 3 comments
Closed

wishbone.bus: add Arbiter. #3

nmigen-issue-migration opened this issue Jan 22, 2020 · 3 comments

Comments

@nmigen-issue-migration
Copy link

Issue by jfng
Wednesday Jan 22, 2020 at 14:18 GMT
Originally opened as m-labs/nmigen-soc#3

This arbiter should be compatible with all the optional features of wishbone.Interface.

The round-robin implementation could perhaps be moved to nmigen.lib and imported back here, but that would make nmigen-soc depend on a later revision than nmigen v0.1.

jfng included the following code: https://github.com/m-labs/nmigen-soc/pull/3/commits
@nmigen-issue-migration
Copy link
Author

Comment by codecov[bot]
Wednesday Jan 22, 2020 at 14:19 GMT

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         415    474   +59     
  Branches       91    111   +20     
=====================================
+ Hits          415    474   +59
Impacted Files Coverage Δ
nmigen_soc/wishbone/bus.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3195de9...87281d1. Read the comment docs.

@nmigen-issue-migration
Copy link
Author

Comment by jfng
Wednesday Jan 22, 2020 at 15:20 GMT

Corrected a typo in the docstring.

@jfng
Copy link
Member

jfng commented Feb 10, 2020

Superseded by #9.

@jfng jfng closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfng @nmigen-issue-migration