Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.taffybar: Mark as unbroken #79735

Merged
merged 1 commit into from Feb 11, 2020
Merged

haskellPackages.taffybar: Mark as unbroken #79735

merged 1 commit into from Feb 11, 2020

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 10, 2020

...it builds because gi-gdkx11 is no longer broken

Fixes #63500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clkamp
haskellPackages.taffybar: Mark as unbroken
1bf82a6 
...it builds because gi-gdkx11 is no longer broken

Fixes NixOS#63500
@cdepillabout
Copy link
Member

cdepillabout commented Feb 11, 2020 •
edited

Looks like taffybar builds now! Thanks!

@clkamp Thanks for following through with all the PRs required to get this working.

@cdepillabout cdepillabout merged commit 183df02 into NixOS:haskell-updates Feb 11, 2020
@cdepillabout cdepillabout mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clkamp @cdepillabout