Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babelstone-han: 12.1.7 -> 13.0.3 #79665

Merged
merged 1 commit into from Feb 24, 2020
Merged

babelstone-han: 12.1.7 -> 13.0.3 #79665

merged 1 commit into from Feb 24, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Feb 9, 2020

Motivation for this change

This font package is currently broken due to the URL pointing to the new version. Not a huge fan of sourcing from an unversioned, breakable link like this, but I guess there's no upstream alternative; Debian caches the source archives, but only has old versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
Copy link
Member Author

emilazy commented Feb 9, 2020 •
edited

(Is there any way to get the fetchzip download cached by Hydra, at least, so that the package doesn't break when the font is updated upstream?)

Edit: Oh, I guess that would just be removing the hydraPlatforms = [];. I presume it's there for a reason, though, but I'm not sure what; the license appears to permit free redistribution. @volth?

@emilazy emilazy requested a review from volth February 9, 2020 23:41
@emilazy
Copy link
Member Author

emilazy commented Feb 10, 2020

@GrahamcOfBorg build babelstone-han

@emilazy
Copy link
Member Author

emilazy commented Feb 10, 2020 •
edited

Updated to allow Hydra builds and also use an Internet Archive snapshot of the zip. (Maybe only one of those is really necessary?)

@ofborg ofborg bot requested a review from volth February 10, 2020 13:26
@lukateras lukateras merged commit fd27f46 into NixOS:master Feb 24, 2020
@emilazy emilazy deleted the babelstone-han-13.0.3 branch February 24, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @lukateras