Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 349b471469fa
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e85e257ad98a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 9, 2020

  1. fzf: fix patch for vim plugin; enable tests; avoid direct $src… (#79575)

    It was previously referencing `$bin`, but this package no longer produces a
    `bin` output, just `out` and `share`. Updated to make the comparison check a bit
    more robust.
    
    Also updated to avoid direct dependency on the `$src` directory out of the nix
    store, instead using the processed src setup in the unpackPhase. This provides a
    cleaner abstraction between the build/install phase and the input src phase, and
    avoids an unnecessary dependency on whether the source disted tarball comes from
    `fetchFromGitHub` (in which case it's an unpacked directory) or something like
    `fetchurl`. In either case, stdenv is responsible for processing the input `src`
    and setting up a clean build dir for us, so we should use that.
    
    This produces an equivalent directory tree, except that the vim plugin is no
    longer broken.
    bhipple committed Feb 9, 2020
    Copy the full SHA
    e85e257 View commit details
    Browse the repository at this point in the history