Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yoshimi: 1.6.1 -> 1.7.0.1 #79694

Merged
merged 2 commits into from Feb 28, 2020
Merged

yoshimi: 1.6.1 -> 1.7.0.1 #79694

merged 2 commits into from Feb 28, 2020

Conversation

ftrvxmtrx
Copy link
Member

@ftrvxmtrx ftrvxmtrx commented Feb 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works.
Thanks @ftrvxmtrx

@cillianderoiste cillianderoiste merged commit ddc2f88 into NixOS:master Feb 28, 2020
magnetophon added a commit to magnetophon/nixpkgs that referenced this pull request Feb 28, 2020
@ftrvxmtrx ftrvxmtrx deleted the yoshimi branch February 28, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants