New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs: pin to 12.x by default #79753
Conversation
3f10a36
to
a2ffd56
Compare
This is not going in release 20.03. It will be part of 20.09. |
I think we should also make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, and it seems this PR has a merge conflict so needs a rebase.
@@ -2,7 +2,7 @@ | |||
|
|||
{pkgs ? import <nixpkgs> { | |||
inherit system; | |||
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}: | |||
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong?
@@ -8941,13 +8941,13 @@ let | |||
sha512 = "bsTwuIg/BZZK/vreVTYYbSWoe2F+71P7K5QGEX+pT250DZbfU1MQ5prOKpPR+LL6uWKK3KMwMCAS74QB3Um1uw=="; | |||
}; | |||
}; | |||
"caniuse-lite-1.0.30001025" = { | |||
"caniuse-lite-1.0.30001027" = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes relevant here?
@@ -4677,7 +4677,7 @@ in | |||
|
|||
nixnote2 = libsForQt5.callPackage ../applications/misc/nixnote2 { }; | |||
|
|||
nodejs = hiPrio nodejs-10_x; | |||
nodejs = hiPrio nodejs-12_x; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I would like this, too. Perhaps also update nodejs-slim
?
Seems this is superseded by #85764 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)