Commits on Feb 10, 2020

1. fetchcargo: use flat tar.gz file for vendored src instead of recursiv… …

   …e hash dir
   
   This has several advantages:
   
   1. It takes up less space on disk in-between builds in the nix store.
   2. It uses less space in the binary cache for vendor derivation packages.
   3. It uses less network traffic downloading from the binary cache.
   4. It plays nicely with hashed mirrors like tarballs.nixos.org, which only
      substitute --flat hashes on single files (not recursive directory hashes).
   5. It's consistent with how simple `fetchurl` src derivations work.
   6. It provides a stronger abstraction between input src-package and output
      package, e.g., it's harder to accidentally depend on the src derivation at
      runtime by referencing something like `${src}/etc/index.html`. Likewise, in
      the store it's harder to get confused with something that is just there as a
      build-time dependency vs. a runtime dependency, since the build-time
      src dependencies are tarred up.
   
   Disadvantages are:
   1. It takes slightly longer to untar at the start of a build.
   
   As currently implemented, this attaches the compacted vendor.tar.gz feature as a
   rider on `verifyCargoDeps`, since both of them are relatively newly implemented
   behavior that change the `cargoSha256`.
   
   If this PR is accepted, I will push forward the remaining rust packages with a
   series of treewide PRs to update the `cargoSha256`s.

   

   bhipple committed Feb 10, 2020
   Copy the full SHA

   2115a20 View commit details

   Browse the repository at this point in the history

2. Merge pull request #78501 from bhipple/feature/fetchcargo-tar-gz …

   fetchcargo: use flat tar.gz file for vendored src instead of recursive hash dir

   

   zimbatm committed Feb 10, 2020
   Copy the full SHA

   15a51f6 View commit details

   Browse the repository at this point in the history