Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicad-unstable: update update.sh and update #79672

Merged
merged 2 commits into from Feb 10, 2020
Merged

Kicad-unstable: update update.sh and update #79672

merged 2 commits into from Feb 10, 2020

Conversation

evils
Copy link
Member

@evils evils commented Feb 10, 2020 •
edited

Motivation for this change

fix update.sh to work for most people

Things done

use /tmp instead of /run/user/1000 (the default for nix-prefetch-url) which is usually set to 10% of RAM
bump unstable to latest
shorten a some internal names

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils
kicad: simplify component names
a3df9da
@evils
kicad-unstable: update update.sh && update
0c1c1dc 
use /tmp instead of XDG_RUNTIME_DIR
  which is /run/user/1000, which defaults to 10% of RAM
  and kicad-packages3d needs ~6gb
@ofborg ofborg bot requested a review from Kiwi February 10, 2020 01:38
@FRidh FRidh merged commit d3a9e63 into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evils @FRidh