Add some Guile packages #79650

JohnAZoidberg · 2020-02-09T19:40:00Z

Motivation for this change

They're needed for building GNU Guix from source ;)

Guix 1.0 already builds with this, but needs a little more tweaking.

Things done

doronbehar · 2020-03-12T16:42:03Z

pkgs/development/guile-modules/guile-ssh/default.nix

+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig which texinfo ];  # Which is probably a hack
+  buildInputs = [ guile libssh ]; # Maybe use libssh2


Maybe use libssh2

Just out of curiosity, what did you mean?

stale · 2020-09-09T14:14:19Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

SuperSandro2000

Please use fetchgit for getting archives from https://notabug.org.

SuperSandro2000 · 2020-12-29T04:21:41Z

pkgs/development/guile-modules/guile-bytestructures/default.nix

@@ -0,0 +1,30 @@
+{ stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, guile }:
+stdenv.mkDerivation rec {


Suggested change

stdenv.mkDerivation rec {

stdenv.mkDerivation rec {

SuperSandro2000 · 2020-12-29T04:21:47Z

pkgs/development/guile-modules/guile-bytestructures/default.nix

+    sha256 = "0q0habjiy3h9cigb7q1br9kz6z212dn2ab31f6dgd3rrmsfn5rvb";
+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig ];


Suggested change

nativeBuildInputs = [ autoreconfHook pkgconfig ];

nativeBuildInputs = [ autoreconfHook pkg-config ];

SuperSandro2000 · 2020-12-29T04:21:53Z

pkgs/development/guile-modules/guile-bytestructures/default.nix

@@ -0,0 +1,30 @@
+{ stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, guile }:


Suggested change

{ stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, guile }:

{ stdenv, fetchFromGitHub, autoreconfHook, pkg-config, guile }:

SuperSandro2000 · 2020-12-29T04:22:13Z

pkgs/development/guile-modules/guile-gcrypt/default.nix

+    sha256 = "1qj1yw0kman984x584jjjxnjdhm0pwgp09iyn3b5rqajx7svpqcd";
+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig texinfo ];


Suggested change

nativeBuildInputs = [ autoreconfHook pkgconfig texinfo ];

nativeBuildInputs = [ autoreconfHook pkg-config texinfo ];

SuperSandro2000 · 2020-12-29T04:22:17Z

pkgs/development/guile-modules/guile-gcrypt/default.nix

@@ -0,0 +1,29 @@
+{ stdenv, fetchurl, autoreconfHook, pkgconfig, texinfo, guile, libgcrypt }:


Suggested change

{ stdenv, fetchurl, autoreconfHook, pkgconfig, texinfo, guile, libgcrypt }:

{ stdenv, fetchurl, autoreconfHook, pkg-config, texinfo, guile, libgcrypt }:

SuperSandro2000 · 2020-12-29T04:39:09Z

pkgs/development/guile-modules/guile-sqlite3/default.nix

@@ -0,0 +1,21 @@
+{ stdenv, fetchurl, autoreconfHook, pkgconfig, guile, sqlite }:


Suggested change

{ stdenv, fetchurl, autoreconfHook, pkgconfig, guile, sqlite }:

{ stdenv, fetchurl, autoreconfHook, pkg-config, guile, sqlite }:

SuperSandro2000 · 2020-12-29T04:39:23Z

pkgs/development/guile-modules/guile-sqlite3/default.nix

+    sha256 = "1s9gmj72vszn999c82vnq0vic7ly4wcg8lz1qcfmhgk9pihcs0bm";
+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig ];


Suggested change

nativeBuildInputs = [ autoreconfHook pkgconfig ];

nativeBuildInputs = [ autoreconfHook pkg-config ];

SuperSandro2000 · 2020-12-29T04:39:45Z

pkgs/development/guile-modules/guile-ssh/default.nix

@@ -0,0 +1,23 @@
+{ stdenv, fetchFromGitHub, fetchpatch, autoreconfHook, pkgconfig, which, texinfo, guile, libssh }:


Suggested change

{ stdenv, fetchFromGitHub, fetchpatch, autoreconfHook, pkgconfig, which, texinfo, guile, libssh }:

{ stdenv, fetchFromGitHub, fetchpatch, autoreconfHook, pkg-config, which, texinfo, guile, libssh }:

SuperSandro2000 · 2020-12-29T04:40:02Z

pkgs/development/guile-modules/guile-ssh/default.nix

+    sha256 = "054hd9rzfhb48gc1hw3rphhp0cnnd4bs5qmidy5ygsyvy9ravlad";
+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig which texinfo ];  # Which is probably a hack


Suggested change

nativeBuildInputs = [ autoreconfHook pkgconfig which texinfo ]; # Which is probably a hack

nativeBuildInputs = [ autoreconfHook pkg-config which texinfo ];

SuperSandro2000 · 2020-12-29T04:40:24Z

pkgs/development/guile-modules/guile-ssh/default.nix

+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig which texinfo ];  # Which is probably a hack
+  buildInputs = [ guile libssh ]; # Maybe use libssh2


On what depends this decision?

SuperSandro2000 · 2020-12-29T04:44:38Z

Result of nixpkgs-review pr 79650 run on x86_64-linux 1

6 packages built:

guile-bytestructures
guile-gcrypt
guile-git
guile-json
guile-sqlite3
guile-ssh

SuperSandro2000 · 2020-12-29T04:44:47Z

Result of nixpkgs-review pr 79650 run on x86_64-darwin 1

6 packages built:

guile-bytestructures
guile-gcrypt
guile-git
guile-json
guile-sqlite3
guile-ssh

jgarte · 2021-07-27T11:19:46Z

Hi, was this the only thing blocking this pull request, the notabug requested url change?

I'd be happy to work on this in order to finish adding these packages.

SuperSandro2000 · 2021-07-27T12:47:25Z

Hi, was the only think blocking this pull request the notabug requested url change?

I'd be happy to work on this in order to finish adding these packages.

no, there a few other things which now no longer work.

stale · 2022-04-19T08:16:03Z

I marked this as stale due to inactivity. → More info

doronbehar · 2022-04-19T16:53:38Z

Closing due to not response from OP.

JohnAZoidberg added 6 commits February 9, 2020 20:18

guile-bytestructures: init at 1.0.7

309f191

guile-sqlite3: init at 0.1.0

99854c0

guile-ssh: init at 0.12.0

064bb8a

guile-gcrypt: init at 0.2.1

6ba2a54

guile-json: init at 3.3.0

9b5e0c5

guile-git: init at 0.3.0

67cc18f

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 9, 2020

doronbehar reviewed Mar 12, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 9, 2020

SuperSandro2000 requested changes Dec 29, 2020

View reviewed changes

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2020

ethancedwards8 requested a review from doronbehar March 6, 2021 20:42

veprbl added the 2.status: merge conflict label Aug 3, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022

doronbehar closed this Apr 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some Guile packages #79650

Add some Guile packages #79650

JohnAZoidberg commented Feb 9, 2020

doronbehar Mar 12, 2020

stale bot commented Sep 9, 2020

SuperSandro2000 left a comment

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 Dec 29, 2020

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Dec 29, 2020

jgarte commented Jul 27, 2021 •

edited

SuperSandro2000 commented Jul 27, 2021

stale bot commented Apr 19, 2022

doronbehar commented Apr 19, 2022

		@@ -0,0 +1,30 @@
		{ stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, guile }:
		stdenv.mkDerivation rec {

	nativeBuildInputs = [ autoreconfHook pkgconfig ];
	nativeBuildInputs = [ autoreconfHook pkg-config ];

		@@ -0,0 +1,29 @@
		{ stdenv, fetchurl, autoreconfHook, pkgconfig, texinfo, guile, libgcrypt }:

	{ stdenv, fetchurl, autoreconfHook, pkgconfig, texinfo, guile, libgcrypt }:
	{ stdenv, fetchurl, autoreconfHook, pkg-config, texinfo, guile, libgcrypt }:

		@@ -0,0 +1,21 @@
		{ stdenv, fetchurl, autoreconfHook, pkgconfig, guile, sqlite }:

		@@ -0,0 +1,23 @@
		{ stdenv, fetchFromGitHub, fetchpatch, autoreconfHook, pkgconfig, which, texinfo, guile, libssh }:

Add some Guile packages #79650

Add some Guile packages #79650

Conversation

JohnAZoidberg commented Feb 9, 2020

Motivation for this change

Things done

Choose a reason for hiding this comment

stale bot commented Sep 9, 2020

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Dec 29, 2020

jgarte commented Jul 27, 2021 • edited

SuperSandro2000 commented Jul 27, 2021

stale bot commented Apr 19, 2022

doronbehar commented Apr 19, 2022

jgarte commented Jul 27, 2021 •

edited