Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osm2pgsql: enable on darwin #79755

Merged
merged 1 commit into from Feb 17, 2020
Merged

osm2pgsql: enable on darwin #79755

merged 1 commit into from Feb 17, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Feb 10, 2020

Motivation for this change
  • Enable on Darwin
  • Add withLuaJIT option, see README:

Performance measurements have shown about 25% runtime reduction for a planet import, with about 40% reduction on parsing time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 merged commit e2c3b16 into NixOS:master Feb 17, 2020
@sikmir sikmir deleted the osm2pgsql branch February 17, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants