Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cvsq: init at 1.10 #79737

Merged
merged 1 commit into from Feb 26, 2020
Merged

cvsq: init at 1.10 #79737

merged 1 commit into from Feb 26, 2020

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clkamp
Copy link
Contributor Author

clkamp commented Feb 19, 2020

Are there any further steps needed to get this merged?

@doronbehar
Copy link
Contributor

Not really, you may want to try and get some attention at https://discourse.nixos.org/t/prs-already-reviewed/2617

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/102

@madjar
Copy link
Member

madjar commented Feb 26, 2020

Also tested on osx.

@madjar madjar merged commit 186cd76 into NixOS:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clkamp @doronbehar @nixos-discourse @madjar