glibc, openssl: unbreak cross eval (with minor caveats) #79738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's certainly better to have those two caveats than not evaluate. Both seem rather niche. Unfortunately I failed to find a better way. I started testing builds of several cross variants; all seem OK.
vcunat
added
0.kind: bug
0.kind: regression
Ericson2314
approved these changes
Feb 10, 2020
|
Tested building bash on some cross examples that came into my mind: nix build -f . bash --arg crossSystem '(import ./lib).systems.examples.armv7l-hf-multiplatform'
nix build -f . bash --arg crossSystem '(import ./lib).systems.examples.aarch64-multiplatform'
nix build -f . bash --arg crossSystem '(import ./lib).systems.examples.musl64' |
|
Is the |
|
It's separate in the sense of being put into a separate derivation output, |
| separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) && stdenv.cc.isGNU; | ||
| separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) | ||
| && stdenv.hostPlatform == stdenv.buildPlatform # unable to fix infinite recursion on stdenv.cc | ||
| && stdenv.cc.isGNU; |
There was a problem hiding this comment.
the fix is good, but it sounds like we need to tweak llvm to work with separate-debug-info.sh, since I bet that everything is broken, not just openssl.
There was a problem hiding this comment.
Right, that certainly seems preferable, but I have no idea about difficulty of that :-)
matthewbauer
approved these changes
Feb 10, 2020
|
I merged relatively fast to avoid additional cherry-pick after 20.03 branch-off. We can improve later if there's an idea how. |
vcunat
added a commit
to vcunat/nixpkgs
that referenced
this pull request
Feb 14, 2020
Thanks to python3Minimal. This reverts part of c203848 NixOS#79738.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's certainly better to have those two caveats than not evaluate.
Both seem rather niche. Unfortunately I failed to find a better way.
I started testing builds of several cross variants; all seem OK.
Fixes #79610 (with minor caveats)