Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: fix runInMachineWithX/runInMachine #79659

Merged
merged 3 commits into from Feb 14, 2020
Merged

testing: fix runInMachineWithX/runInMachine #79659

merged 3 commits into from Feb 14, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This is for both the python and perl driver.
The both shared the same breakage from c95612a, and the python driver had unported testing scripts for these functions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
testing-python: fix runInMachine
fa9af83 
The test script's were unported.
It's unclear whether the preBuild or
postBuild will work as expect, due to
the linting of the test scripts.
@worldofpeace
testing-python: readd auto displayManager
88f7681 
we import it for the runInMachineWithX
@worldofpeace
testing: fix runInMachineWithX
5507e09
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 9, 2020
@worldofpeace worldofpeace added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 9, 2020
@worldofpeace worldofpeace mentioned this pull request Feb 14, 2020
Merged
10 tasks
@worldofpeace worldofpeace merged commit 95e41ec into NixOS:master Feb 14, 2020
@worldofpeace worldofpeace deleted the cleanup-python-test-lib branch February 14, 2020 17:39
@worldofpeace
Copy link
Contributor Author

Need to backport this.

@worldofpeace worldofpeace mentioned this pull request Feb 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @flokli