Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: Port initial configurations from Plasma 5.16 #79744

Merged
merged 1 commit into from Feb 10, 2020
Merged

nixos/plasma5: Port initial configurations from Plasma 5.16 #79744

merged 1 commit into from Feb 10, 2020

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Feb 10, 2020 •
edited

Motivation for this change

The Plasma 5.17 update lost some initial configurations and manual cache invalidation that was previously performed by our modified startkde script. These modifications were lost when startkde was rewritten upstream. Now the required workarounds are included in the NixOS module where they arguably belonged in the first place.

Related: #79707

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel merged commit fb098ea into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ttuegel