Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysaml2: 4.9.0 -> 5.0.0, addressing CVE-2020-5390 #79662

Merged
merged 1 commit into from Feb 10, 2020
Merged

pythonPackages.pysaml2: 4.9.0 -> 5.0.0, addressing CVE-2020-5390 #79662

merged 1 commit into from Feb 10, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Feb 9, 2020

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-5390

Disabled for python 2.7 as support is being removed from this release on. Will probably try and patch 19.09 so we don't need to disable for 2.7 mid-release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.pysaml2: 4.9.0 -> 5.0.0 (security)
9b04703 
addressing CVE-2020-5390. disabled for python 2.7 as support is being
removed from this release on.
@jonringer
Copy link
Contributor

@GrahamcOfBorg test matrix-synapse

jonringer
jonringer approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/79662
3 package built:
matrix-synapse python37Packages.pysaml2 python38Packages.pysaml2

@jonringer jonringer merged commit 55ace3b into NixOS:master Feb 10, 2020
@risicle risicle mentioned this pull request Feb 10, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer