Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cemu: init at 1.3 #79661

Merged
merged 2 commits into from Mar 31, 2020
Merged

cemu: init at 1.3 #79661

merged 2 commits into from Mar 31, 2020

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented Feb 9, 2020 •
edited

Motivation for this change

Added cemu app

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Feb 10, 2020

@GrahamcOfBorg build cemu

@aanderse
Copy link
Member

aanderse commented Feb 10, 2020 •
edited

So there are two emulators called cemu?

@luc65r
Copy link
Contributor Author

luc65r commented Feb 10, 2020

So there are two emulators called cemu?

Yes...

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/123

@aanderse
Copy link
Member

Has anyone tested this? Seems like an easy merge. @luc65r ping me back in a few days of no one else reports back on this and I'll test+merge it. Make sense to you @mmahut?

@luc65r
Copy link
Contributor Author

luc65r commented Mar 28, 2020

@aanderse It seems like no one is interested in testing and merging it. If you could do it, it would be nice, but it isn't urgent.

timokau
timokau approved these changes Mar 31, 2020
View reviewed changes
maintainers/maintainer-list.nix
github = "luc65r";
githubId = 59375051;
name = "Lucas Ransan";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@timokau timokau merged commit 83fd899 into NixOS:master Mar 31, 2020
@luc65r luc65r deleted the pkg/cemu branch April 25, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@timokau timokau timokau approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@luc65r @mmahut @aanderse @nixos-discourse @timokau @doronbehar @Janik-Haag