Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysnow: init at 0.7.14 #79687

Merged
merged 2 commits into from Feb 12, 2020
Merged

pythonPackages.pysnow: init at 0.7.14 #79687

merged 2 commits into from Feb 12, 2020

Conversation

a1mac
Copy link

@a1mac a1mac commented Feb 10, 2020

Motivation for this change

Adding pysnow into nixpkgs and adding myself as the maintainer for the package.

Note

Separate commit with the maintainer info only was denied: #79160
I have a few more packages that I would like to add given that this one is accepted

Things done

I tested builds with different versions of python on centos with nixpkgs.
I did integration testing with py37 on nixos (nix-shell).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 10, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/pysnow/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@a1mac
Copy link
Author

a1mac commented Feb 11, 2020

Working on fixing it, please don't close. Thanks!

jonringer
jonringer approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[12 built, 210 copied (781.5 MiB), 141.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79687
3 package built:
python27Packages.pysnow python37Packages.pysnow python38Packages.pysnow

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pysnow python37Packages.pysnow python38Packages.pysnow

@jonringer jonringer merged commit efc75b3 into NixOS:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a1mac @jonringer @FRidh