Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merriweather{,-sans}: add new fonts #79686

Merged
merged 2 commits into from Feb 24, 2020
Merged

merriweather{,-sans}: add new fonts #79686

merged 2 commits into from Feb 24, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Feb 10, 2020 •
edited

Motivation for this change

Merriweather is a popular OFL-licensed font on Google Fonts; its metrics are comparable to Georgia, making it a good freely-licensed replacement. I've also included its sister Sans face. It's already packaged in openSUSE, Alpine and the Arch User Repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
Copy link
Member Author

emilazy commented Feb 10, 2020

@GrahamcOfBorg build merriweather merriweather-sans

@emilazy
Copy link
Member Author

emilazy commented Feb 11, 2020

Updated to use stdenvNoCC to cut down on extraneous rebuilds.

@GrahamcOfBorg build merriweather merriweather-sans

@lukateras lukateras merged commit 2ee99b4 into NixOS:master Feb 24, 2020
@emilazy emilazy deleted the add-merriweather-fonts branch February 24, 2020 19:31
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 24, 2020
@lukateras @dtzWill
Merge pull request NixOS#79686 from emilazy/add-merriweather-fonts
d8ddf00 
merriweather{,-sans}: add new fonts

(cherry picked from commit 2ee99b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @lukateras