Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades coursier to 2.0.0-RC6-4 #79700

Merged
merged 1 commit into from Feb 13, 2020
Merged

Upgrades coursier to 2.0.0-RC6-4 #79700

merged 1 commit into from Feb 13, 2020

Conversation

tabdulradi
Copy link
Contributor

First PR here 馃憢 Still trying to figure out the process.
I calculated the hashes by executing this bash

version="2.0.0-RC6-4"
nix-prefetch-url "https://raw.githubusercontent.com/coursier/coursier/v${version}/modules/cli/src/main/resources/completions/zsh"
nix-prefetch-url "https://github.com/coursier/coursier/releases/download/v${version}/coursier"

and copying the hash from the output of each command.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Feb 13, 2020

@GrahamcOfBorg build coursier

@mmahut mmahut merged commit 0306934 into NixOS:master Feb 13, 2020
@tabdulradi tabdulradi deleted the patch-2 branch February 13, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants