New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weechatScripts.weechat-matrix: unstable-2019-11-10 -> unstable-2020-01-21 #79669
Conversation
4719f47
to
cc6540e
Compare
Updated to include the new @GrahamcOfBorg build weechatScripts.weechat-matrix |
cc6540e
to
6a88b65
Compare
Missed a dependency for the SSO helper that wasn't actually affecting anything because it was coming in indirectly via @GrahamcOfBorg build weechatScripts.weechat-matrix cc @tilpner |
pkgs/applications/networking/irc/weechat/scripts/weechat-matrix/default.nix
Show resolved
Hide resolved
pkgs/applications/networking/irc/weechat/scripts/weechat-matrix/default.nix
Outdated
Show resolved
Hide resolved
6a88b65
to
1268ee4
Compare
pushed with requested tweaks ^^ |
when I tested this I ran into #79646 |
As far as I'm aware that's just due to the nature of the nixpkgs WeeChat configuration; you need to ensure WeeChat's Python picks up the necessary package dependencies: { pkgs, ... }:
{
environment.systemPackages = with pkgs; [
# ...
(weechat.override {
configure = {availablePlugins, ...}: with weechatScripts; {
plugins = with availablePlugins; [
(python.withPackages (_: weechat-matrix.propagatedBuildInputs))
];
scripts = [ weechat-matrix ];
};
})
weechatScripts.weechat-matrix
];
} It would be nicer if this happened automatically, but unless I'm mistaken I think it's orthogonal to this update. |
|
@emilazy Is there a reason this is marked as unsupported on macOS? Seems to build fine. |
probably a previous issue that blocked mac support. Pretty common |
@mjlbach not to my knowledge; feel free to submit a PR that changes it to |
Motivation for this change
Updated the sources and dependencies for matrix-nio and its dependent weechat-matrix. Not tested extensively, but "it builds".
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)