Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spleen: install otf font #79671

Merged
merged 1 commit into from Feb 11, 2020
Merged

spleen: install otf font #79671

merged 1 commit into from Feb 11, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 10, 2020

Motivation for this change

Issue #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested fonts are working in X11 and GTK application
  • Tested compilation of all pkgs that depend on this change using
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj mentioned this pull request Feb 10, 2020
Closed
19 tasks
@ofborg ofborg bot requested a review from dtzWill February 10, 2020 01:10
@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Feb 11, 2020 •
edited

Looks good, files are there and are valid fonts - tested with ImageMagick's display.

results/spleen/share/
├── consolefonts
│   ├── spleen-12x24.psfu
│   ├── spleen-16x32.psfu
│   ├── spleen-32x64.psfu
│   ├── spleen-5x8.psfu
│   └── spleen-8x16.psfu
└── fonts
    └── misc
        ├── fonts.alias
        ├── fonts.dir
        ├── spleen-12x24.bdf
        ├── spleen-12x24.pcf
        ├── spleen-16x32.bdf
        ├── spleen-16x32.pcf
        ├── spleen-32x64.bdf
        ├── spleen-32x64.pcf
        ├── spleen-5x8.bdf
        ├── spleen-5x8.pcf
        ├── spleen-8x16.bdf
        ├── spleen-8x16.pcf
        └── spleen.otf

@JohnAZoidberg JohnAZoidberg merged commit 9b2d529 into NixOS:master Feb 11, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 11, 2020

Thank you!

@rnhmjoj rnhmjoj deleted the spleen branch April 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @JohnAZoidberg