Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road Construction UI unavailable #8055

Closed
Irokis opened this issue Apr 3, 2020 · 3 comments · Fixed by #8521
Closed

Road Construction UI unavailable #8055

Irokis opened this issue Apr 3, 2020 · 3 comments · Fixed by #8521
Labels
regression It used to work, and now it's broken.
Milestone

Comments

@Irokis
Copy link

Irokis commented Apr 3, 2020

If you start the game with Maximum number of road vehicles per company: 0, u cannot build any road, the button is just greyed out and disabled. If you go into settings while in that game and set the number of vehicles to 100, the road construction becomes available and u can build road, but if you go back into settings set the road vehicle limit back to 0 WITHOUT closing the ROAD CONSTRUCTION UI the game just crashes.

Version of OpenTTD

openttd-1.10.0-windows-win64.exe

Expected result

To be able to do road construction even tho the allowed road vehicle per company is set to 0

Actual result

The road construction is greyed out, if road vehicle per company is set to 0. Also crashes OpenTTD if you leave the Road Construction UI on, while going into Settings to change road vehicles per company 100 -> 0.

Steps to reproduce

  1. Create any game with Limitations -> Maximum number of road vehicles per company: 0
  2. Go into Settings while in the created game.
  3. Find Limitations -> Maximum Number of road vehicles per company, set it to 100
  4. Road Construction becomes available, select it, build some road whatever doesnt matter.
  5. Do not close Road Construction UI.
  6. Go back into Settings -> Limitations -> Maximum number of road vehicles per company, set it back 100 -> 0.
  7. Game crashes.
@James103
Copy link
Contributor

James103 commented Apr 3, 2020

What exactly is the crash? If possible, can you please upload the crash report and dump file?

@Irokis
Copy link
Author

Irokis commented Apr 3, 2020

RoadUIcrash.zip
The crash is that the whole OpenTTD just closes, no ERROR nothing.

stormcone added a commit to stormcone/OpenTTD that referenced this issue Apr 3, 2020
…ailability of the current road type has changed.
@glx22 glx22 added bug Something isn't working regression It used to work, and now it's broken. and removed bug Something isn't working labels Apr 3, 2020
stormcone added a commit to stormcone/OpenTTD that referenced this issue Apr 5, 2020
…ailability of the current road type has changed.
stormcone added a commit to stormcone/OpenTTD that referenced this issue Apr 5, 2020
…ut the availability of the current road type has changed.
@LordAro LordAro closed this as completed in 2514f43 Apr 5, 2020
@LordAro
Copy link
Member

LordAro commented Apr 5, 2020

Crash now fixed, still need to address road building availability

@LordAro LordAro reopened this Apr 5, 2020
LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 5, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Apr 13, 2020
LordAro pushed a commit that referenced this issue Apr 13, 2020
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 5, 2021
@TrueBrain TrueBrain changed the title Road Construction UI unavailable, also potential OpenTTD crash Road Construction UI unavailable Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression It used to work, and now it's broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants