Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cryptography: 2.8 -> 2.9 #84192

Merged
merged 1 commit into from Apr 5, 2020
Merged

python3Packages.cryptography: 2.8 -> 2.9 #84192

merged 1 commit into from Apr 5, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 3, 2020 •
edited

Backwards incompatible changes:

  • Support for Python 3.4 has been removed due to low usage and
    maintenance burden.
  • Support for OpenSSL 1.0.1 has been removed. Users on older version of
    OpenSSL will need to upgrade.
  • Support for LibreSSL 2.6.x has been removed.
  • Reversed the order in which rfc4514_string() returns the RDNs as
    required by RFC 4514.

Note: The first three changes should have no impact on Nixpkgs as we
already removed Python 3.4 and OpenSSL 1.0.1. Additionally we don't
support LibreSSL for this package.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
python3Packages.cryptography: 2.8 -> 2.9
43af4fb 
Backwards incompatible changes:
- Support for Python 3.4 has been removed due to low usage and
  maintenance burden.
- Support for OpenSSL 1.0.1 has been removed. Users on older version of
  OpenSSL will need to upgrade.
- Support for LibreSSL 2.6.x has been removed.
- Reversed the order in which rfc4514_string() returns the RDNs as
  required by RFC 4514.

Note: The first three changes should have no impact on Nixpkgs as we
already removed Python 3.4 and OpenSSL 1.0.1. Additionally we don't
support LibreSSL for this package.
wamserma
wamserma approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and did not break anything so far.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.requests
@GrahamcOfBorg build python38Packages.requests

@FRidh FRidh added this to Ready in Staging Apr 3, 2020
@FRidh FRidh merged commit af1cb9f into NixOS:staging Apr 5, 2020
Staging automation moved this from Ready to Done Apr 5, 2020
@primeos primeos mentioned this pull request Apr 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @jonringer @wamserma @FRidh