Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the flight plan when the last manœuvre is moved forward or extended #2518

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Apr 2, 2020

Also changed the default flight plan length to 1 hour from 1000 seconds (?).

Fix #852.

// plan is too short, extend the flight plan.
if (manœuvre.IsAfter(start_of_previous_coast(index))) {
desired_final_time_ =
std::max(desired_final_time_, manœuvre.final_time());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we are unable to reach desired_final_time_?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will bubble up a status to the C# and it will say something like "reached the maximum number of steps, try to increase it". Which is exactly the behaviour if you had extended the trajectory by hand.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Apr 3, 2020
@pleroy pleroy merged commit d6da6ca into mockingbirdnest:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prolong flight plan when pushing the last burn forward
2 participants