Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninjas2: init at 0.2.0 #84302

Merged
merged 1 commit into from May 5, 2020
Merged

ninjas2: init at 0.2.0 #84302

merged 1 commit into from May 5, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member Author

Fixed conflicts.

@AndersonTorres
Copy link
Member

ofBorg is failing; why?

@magnetophon
Copy link
Member Author

@AndersonTorres I missed that, good catch!
Fixed now.

@AndersonTorres AndersonTorres merged commit 15e583c into NixOS:master May 5, 2020
@magnetophon magnetophon deleted the ninjas2 branch May 6, 2020 02:29
wizeman added a commit to wizeman/nixpkgs that referenced this pull request Jun 10, 2020
Fix config options for linux_hardened and linux_latest_hardened due
to NixOS#84302.
This is a continuation of NixOS#88946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants