Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] python3Packages.pint: 0.9 -> 0.11 #84216

Merged
merged 2 commits into from Apr 3, 2020
Merged

[20.03] python3Packages.pint: 0.9 -> 0.11 #84216

merged 2 commits into from Apr 3, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Apr 3, 2020 •
edited

Motivation for this change

Backport #84197 to 20.03 to fix python38Packages.pint Hydra failure.
Updates datasette b/c that was broken by pint update.
Disables pint on py27

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.pint: 0.9 -> 0.11
029276f 
(cherry picked from commit 4b822bb)
@drewrisinger
datasette: 0.35 -> 0.39
a1d1b7a 
(cherry picked from commit fb25290)
@drewrisinger
Copy link
Contributor Author

@bhipple backported #84197
@GrahamcOfBorg build python37Packages.pint python38Packages.pint datasette
Builds clean locally with nixpkgs-review pr 84216:

https://github.com/NixOS/nixpkgs/pull/84216
17 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.prl-tools php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.php_excel php74Packages.v8 python37Packages.notify python38Packages.notify

3 package built:
datasette python37Packages.pint python38Packages.pint

@drewrisinger drewrisinger marked this pull request as ready for review April 3, 2020 22:20
bhipple
bhipple approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 84216 1

17 package marked as broken and skipped: - linuxPackages_hardkernel_4_14.prl-tools - php72Packages-unit.php_excel - php72Packages-unit.v8 - php72Packages-unit.v8js - php72Packages.php_excel - php72Packages.v8 - php72Packages.v8js - php73Packages-unit.php_excel - php73Packages-unit.v8 - php73Packages.php_excel - php73Packages.v8 - php74Packages-unit.php_excel - php74Packages-unit.v8 - php74Packages.php_excel - php74Packages.v8 - python37Packages.notify - python38Packages.notify
3 package built: - datasette (python37Packages.datasette) - python37Packages.pint - python38Packages.pint

@bhipple bhipple merged commit e8610d7 into NixOS:release-20.03 Apr 3, 2020
@drewrisinger drewrisinger deleted the dr-pr-backport-20.03-84197 branch April 4, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @bhipple @grahamc