Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-gazelle: init at 0.20.0 #84222

Merged
merged 1 commit into from Apr 6, 2020
Merged

bazel-gazelle: init at 0.20.0 #84222

merged 1 commit into from Apr 6, 2020

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Apr 4, 2020 •
edited

Motivation for this change

Gazelle is a Bazel build file generator for Bazel projects. It natively supports Go and protobuf, and it may be extended to support new languages and custom rule sets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

kalbasit commented Apr 4, 2020

@GrahamcOfBorg build bazel-gazelle

@kalbasit
Copy link
Member Author

kalbasit commented Apr 6, 2020

works on my Mac. I don't think the error on Darwin is related to this change.

@GrahamcOfBorg build bazel-gazelle

@kalbasit kalbasit merged commit a5e6fa6 into NixOS:master Apr 6, 2020
@kalbasit kalbasit deleted the init-bazel-gazelle branch April 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kalbasit