Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.uvloop: enable on python3.8 #84223

Merged
merged 1 commit into from Apr 4, 2020
Merged

python3Packages.uvloop: enable on python3.8 #84223

merged 1 commit into from Apr 4, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Apr 4, 2020 •
edited

Motivation for this change

Allow build pass by disabling test. Isolated issue to test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race.
This test is supposed to be skipped for asynico, but it isn't for some reason,
so we disable it instead.
See uvloop#284 (MagicStack/uvloop#284) for full details. Don't know why this test isn't properly skipped.

Causing hydra build failure.
ZHF: #80379
Will backport to 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip".
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
python3Packages.uvloop: enable on python3.8
364909d 
Allow build pass by disabling test. Isolated issue to
test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race.
This test is supposed to be skipped, but it isn't for some reason,
so we disable it instead.
See uvloop#284 (MagicStack/uvloop#284)
for full details. Don't know why this test isn't properly skipped.
@drewrisinger
Copy link
Contributor Author

ping @jonringer (you disabled python38Packages.uvloop)
@NixOS/nixos-release-managers

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Apr 4, 2020 •
edited

I feel comfortable disabling this test is because I interpret this section of source:

https://github.com/MagicStack/uvloop/blob/0e72f817ebb99cf432f72e9d7478e482c6ca0f3e/tests/test_sockets.py#L197-L200

as meaning it's supposed to be skipped anyways, and the failing test (asyncio version vs uvloop) seems to be only running the native asyncio library as a comparison.

@drewrisinger drewrisinger mentioned this pull request Apr 4, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from costrouc April 4, 2020 00:55
@drewrisinger
Copy link
Contributor Author

Locally running nixpkgs-review pr 84223:

#84223
42 package marked as broken and skipped:
clang-sierraHack digitalbitbox linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.rtl8814au linuxPackages_hardkernel_4_14.rtl8821au linuxPackages_hardkernel_4_14.rtl8821ce linuxPackages_xen_dom0.sch_cake linuxPackages_xen_dom0_hardened.sch_cake octave-jit octoprint php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.caffe python37Packages.notify python38Packages.libselinux python38Packages.notify

32 package built:
datasette google-music-scripts mtprotoproxy python37Packages.aiorun python37Packages.asyncpg python37Packages.databases python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.fastapi python37Packages.google-music python37Packages.httpx python37Packages.orm python37Packages.pproxy python37Packages.qiskit-ibmq-provider python37Packages.sanic python37Packages.sanic-auth python37Packages.sentry-sdk python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.aiorun python38Packages.asyncpg python38Packages.databases python38Packages.fastapi python38Packages.google-music python38Packages.httpx python38Packages.orm python38Packages.pproxy python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

@drewrisinger drewrisinger marked this pull request as ready for review April 4, 2020 00:59
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.uvloop python38Packages.uvloop

@bhipple
Copy link
Contributor

bhipple commented Apr 4, 2020

Looks great, thanks!

bhipple
bhipple approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 84223 1

32 packages built: - datasette (python37Packages.datasette) - google-music-scripts - mtprotoproxy - python37Packages.aiorun - python37Packages.asyncpg - python37Packages.databases - python37Packages.entrance - python37Packages.entrance-with-router-features - python37Packages.fastapi - python37Packages.google-music - python37Packages.httpx - python37Packages.orm - python37Packages.pproxy - python37Packages.qiskit-ibmq-provider - python37Packages.sanic - python37Packages.sanic-auth - python37Packages.sentry-sdk - python37Packages.starlette - python37Packages.uvicorn - python37Packages.uvloop - python38Packages.aiorun - python38Packages.asyncpg - python38Packages.databases - python38Packages.fastapi - python38Packages.google-music - python38Packages.httpx - python38Packages.orm - python38Packages.pproxy - python38Packages.starlette - python38Packages.uvicorn - python38Packages.uvloop - sourcehut.listssrht

@bhipple bhipple merged commit 72f784b into NixOS:master Apr 4, 2020
@jonringer
Copy link
Contributor

main reason i disabled it was that it would hang. and prevent me from reviewing packages. If it's able to build reliably, then I'm more than happy to have it enabled again

@drewrisinger drewrisinger deleted the dr-pr-python-uvloop-fix branch April 4, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@costrouc costrouc Awaiting requested review from costrouc

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @bhipple @jonringer