Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim node packages #84225

Closed
wants to merge 7 commits into from
Closed

Vim node packages #84225

wants to merge 7 commits into from

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 4, 2020 •
edited

Motivation for this change

Don't merge this! Still working on it!

I think having a separate node modules for vim related stuff would be much easier to maintain.

Things I did in this PR:

  • copy over all of the node modules starting with coc-
  • add update-node-modules.sh script (which we should probably run from the update.py)
  • add an option to follow branch, needed for coc.nvim since we should follow release branch there

This PR is not in its final state, I hope to receive feedback. I can also split PR in multiple, but I'd rather not if review is still possible.

If this gets merged i will create a followup PR to remove all of the coc-* packages from current list of node-modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@garbas garbas requested a review from jonringer as a code owner April 4, 2020 01:11
@ofborg ofborg bot requested a review from jorsn April 4, 2020 01:19
@teto teto mentioned this pull request Apr 5, 2020
Closed
@jonringer
Copy link
Contributor

really wish we had a good node vendoring solution, I'm not a big fan of the large deps.nix:

 11,712 pkgs/misc/vim-plugins/node-packages.nix

@garbas
Copy link
Member Author

garbas commented Apr 6, 2020

really wish we had a good node vendoring solution, I'm not a big fan of the large deps.nix:

 11,712 pkgs/misc/vim-plugins/node-packages.nix

Nobody is, but his is what node is all about :)

This PR only moved vim specific packages from common place to vim in order to make it easier to update.

I should also have said I'm using this for the last 10 days and everything related to coc looks to be working.

@jonringer do you have any other objections? ok to include few changes in one PR?

@garbas garbas mentioned this pull request Apr 12, 2020
Merged
10 tasks
@garbas garbas closed this Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @jonringer