Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowchef: init at 0.5.0 #84305

Closed
wants to merge 1 commit into from
Closed

windowchef: init at 0.5.0 #84305

wants to merge 1 commit into from

Conversation

bhougland18
Copy link
Contributor

Motivation for this change

Windowchef is a stacking window manager similar to 2bwm, but more modular in its approach.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes for after you fix the merge conflict. Also, it is preferable that you add yourself as a maintainer in a separate commit, maintainers: add bhougland18.

pkgs/applications/window-managers/windowchef/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/windowchef/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/windowchef/default.nix Show resolved Hide resolved
bhougland18
bhougland18 commented Apr 5, 2020
View reviewed changes
Copy link
Contributor Author

@bhougland18 bhougland18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windowchef: updated maintainer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-can-we-present-nix-nixos-better/6249/52

jonringer
jonringer reviewed Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

This can be done with:

git reset HEAD~7
git add -- pkgs/
git commit --amend --no-edit
git push ... ... --force

@bhougland18
Copy link
Contributor Author

bhougland18 commented Apr 11, 2020 •
edited

@jonringer I folllowed your steps exactly because it seems like this pull request is stuck. However, now there are a lot of issues. Any help?

@bhougland18
Copy link
Contributor Author

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

This can be done with:

git reset HEAD~7
git add -- pkgs/
git commit --amend --no-edit
git push ... ... --force

@bhougland18
Copy link
Contributor Author

I will try again. However, the documentation on how to do this seems very poor.

@jonringer
Copy link
Contributor

I think you had other commits on top of it, my assumption was that you were at the HEAD of the PR branch

@bhougland18
Copy link
Contributor Author

@jonringer no problem, sorry for the bad attitude earlier. I think this commit could be cleaned up anyway and this helps me understand git better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@cole-h cole-h cole-h requested changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@FRidh FRidh Awaiting requested review from FRidh

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: cinnamon 6.topic: emacs 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bhougland18 @nixos-discourse @jonringer @cole-h @timokau