Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 4.1.0 -> 4.3.1 #84190

Merged
merged 1 commit into from Apr 17, 2020
Merged

platformio: 4.1.0 -> 4.3.1 #84190

merged 1 commit into from Apr 17, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 3, 2020

Motivation for this change

Update PlatformIO to its latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi
Copy link
Member Author

oxzi commented Apr 16, 2020

Is there an update on this?

@mogorman, @makefu: Would you be so kind to review this PR as a maintainer.

makefu
makefu approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review and used esphome to compile and deploy an esp8266.
compiling and uploading worked as expected

@Mic92 Mic92 merged commit 61a0306 into NixOS:master Apr 17, 2020
@oxzi oxzi deleted the platformio-4.3.1 branch April 17, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @makefu @Mic92