-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libjpeg_turbo: 2.0.3 -> 2.0.4 #84279
Conversation
cf95be8
to
e380a1f
Compare
... so I assume you want to remove |
And perhaps you want to add yourself into |
e380a1f
to
3ee2782
Compare
3ee2782
to
4692ba3
Compare
Hm. I'm really only sending this PR because (1) I started it thinking libturbojpeg wasn't packaged (and want to add the comment for anyone else grepping), and (2) someone in IRC encouraged me to go ahead and update this one since it's a bugfix behind. I don't use it directly, or know anything about it. I don't mind sending updates for it, or adding it to my list of packages to keep an eye on, but other than that, I'm not qualified to "maintain" this if it ever required any non-trivial maintenance work. What would be the guidance for me? I'm finding myself wondering, "What exactly is the implication of putting my name in that array?". |
There's not much implication; it's still not defined anywhere AFAIK :-) Mainly you get mentioned here when someone wants something about the package. I think @GrahamcOfBorg now automatically requests reviews from EDIT: actually you can see the bot in action just above this comment :-) |
4692ba3
to
e24e8da
Compare
Motivation for this change
Update libjpeg_turbo to latest stable, but mostly doing this to add the comment so someone else doesn't try to package libturbojpeg again.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)