Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacsPackages.lua-mode: Fix hash #84277

Merged
merged 1 commit into from Apr 4, 2020
Merged

emacsPackages.lua-mode: Fix hash #84277

merged 1 commit into from Apr 4, 2020

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Apr 4, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bqv
emacsPackages.lua-mode: Fix hash
df594f1 
for the third time...
@bqv bqv requested a review from adisbladis as a code owner April 4, 2020 20:39
infinisil added a commit to infinisil/lua-mode that referenced this pull request Apr 4, 2020
@infinisil
Don't use non-deterministic %d with git's export-subst
0d3b82f 
This prevents GitHub's tarballs from changing depending on whether a
branch points to the commit or not. E.g. on latest master, %d would
evaluate to "master", whereas once master is updated again, the same
commit wouldn't be master anymore, meaning %d evaluates to "".

This is the cause for PRs NixOS/nixpkgs#56123 and
NixOS/nixpkgs#84277
@infinisil infinisil mentioned this pull request Apr 4, 2020
Closed
@infinisil
Copy link
Member

See immerrr/lua-mode#165 for an upstream fix

@infinisil infinisil merged commit 90e09e1 into NixOS:master Apr 4, 2020
@infinisil
Copy link
Member

Backported to 20.03 in 01ac831

@bhipple
Copy link
Contributor

bhipple commented Apr 5, 2020

This needs 1 more round of fixing after immerrr/lua-mode#166, as it is wrong again :)

trying https://github.com/immerrr/lua-mode/archive/d15bdb18b56f47749aaa2369f1c780525d2eaeec.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   158  100   158    0     0    483      0 --:--:-- --:--:-- --:--:--   481
100 36568    0 36568    0     0  46882      0 --:--:-- --:--:-- --:--:-- 46882
unpacking source archive /build/d15bdb18b56f47749aaa2369f1c780525d2eaeec.tar.gz
hash mismatch in fixed-output derivation '/nix/store/7058a2qgkp3pclbg7a28xmdacy5vsva8-source':
  wanted: sha256:0gs4ixvvnsfiyh0mn7zb9wylqmlf5yl7l96h4n5jhyl78jpyimxm
  got:    sha256:0x1gry716xqszvyb6g7nrwp7izm0zimym55pcahp78gi79agyzk6

(Or a re-run to upgrade to a newer lua-mode version w/ the fix?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bqv @infinisil @bhipple