Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect old urls which are found by analytics #380

Merged
merged 3 commits into from Apr 6, 2020
Merged

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 3, 2020

No description provided.

Makefile Outdated
nixos/packages-explorer.js \
nixpkgs/packages-channels.json


robots.txt: $(HTML)
echo "Users-agent: *" >> $@
echo "Disallow: /" >> $@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not optimal. Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disallow everything first and then allow things we generate. How would you do it otherwise?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to just have Users-agent: *

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm worried disallowing things that don't exist would just simply make 404's stop showing up from search engines, instead of showing up in a way we could fix them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually a very good point. I'll commend the Disallow and Allow lines for now and let search engines catch everything.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2020

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any **/css/*.css in subfolders are actually caused by #354. They should be dropped from this PR if the files are available at the root level, and the 404 page be fixed rather.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2020

@garbas garbas merged commit 373e7ca into master Apr 6, 2020
@garbas garbas deleted the redirect-old-urls branch April 6, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants