Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releaseTools: no-op expression cleanup #83112

Merged
merged 1 commit into from Apr 4, 2020
Merged

releaseTools: no-op expression cleanup #83112

merged 1 commit into from Apr 4, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 22, 2020 •
edited

No functional change, was just reading through these and cleaning/sanitizing
them a bit while I'm here. I'm planning on factoring out some AMI construction logic into a nicer helper function a follow-up.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
releaseTools: no-op expression cleanup
79d875a 
No functional change, was just reading through these and cleaning/sanitizing
them a bit while I'm here.
@matthewbauer matthewbauer merged commit eab992b into NixOS:master Apr 4, 2020
@bhipple bhipple deleted the dev/reltools-cleanup branch May 10, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @matthewbauer