Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs: init at 1.13.4 #84287

Merged
merged 3 commits into from Sep 24, 2020
Merged

vcs: init at 1.13.4 #84287

merged 3 commits into from Sep 24, 2020

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Apr 4, 2020

Motivation for this change

Adding package Video Contact Sheet (vcs), a bash script that generates contact sheets from video files.

Things done
  • I've fixed all runtime binaries using wrapProgram, including coreutils and utillinux. Is that appropriate?
  • The script also pulls in dejavu_fonts to use as its default at runtime, increasing its closure size.
  • This has the same executable name, "vcs", as one provided by package vcstool. Is that a problem?
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran with nix-review on NixOS. Seems to work well even with an empty PATH.

Co-Authored-By: symphorien <symphorien@users.noreply.github.com>
pkgs/applications/video/vcs/default.nix Outdated Show resolved Hide resolved
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
@ryantm
Copy link
Member

ryantm commented Sep 24, 2020

Result of nixpkgs-review pr 84287 1

1 package built:
- vcs

@ryantm ryantm merged commit 028e05d into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants