Skip to content

hashi-ui: init at 1.3.8 #84286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2020
Merged

hashi-ui: init at 1.3.8 #84286

merged 2 commits into from
Apr 27, 2020
+33 −0

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Apr 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

cole-h
cole-h requested changes Apr 4, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you opted for just fetching the binary instead of building it from source? I don't speak with any authority, but I think it's preferable to build from source wherever possible.

@numkem
Copy link
Contributor Author

numkem commented Apr 4, 2020

@cole-h much appreciated for your time. It's my first package and the learning curve is... Curved.

To answer your question about building from source instead. I tried but it requires some yarn packages that aren't in nixpkgs already and the Makefile installs them anyway and gave me errors. While I know this isn't the best approach, it is working and the build is "official" as it's straight from github releases.

@numkem numkem force-pushed the master branch 2 times, most recently from 3ee3882 to 64d2437 Compare April 4, 2020 23:57
cole-h
cole-h requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, but it's understandable. Unless someone else considers that a problem, should be good to go (after you put your maintainer stuff where it belongs, alphabetically).

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 5, 2020
cole-h
cole-h approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nobody else comes along and requests additional changes, LGTM. Binary runs, displays some info, and exits (because it wants Consul and/or Nomad, which I don't have).

https://github.com/NixOS/nixpkgs/pull/84286
20 package marked as broken and skipped:
clang-sierraHack digitalbitbox glibcCross iterm2 linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl php74Packages.pcs python27Packages.caffe python27Packages.flitBuildHook python37Packages.nixpart python38Packages.libselinux python38Packages.nixpart

1 package built:
hashi-ui

@numkem numkem mentioned this pull request Apr 5, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/138

@DamienCassou
Copy link
Contributor

Your PR contains merge commits. Please get rid of them and rebase on top of latest master.

@numkem
maintainers: add numkem
Loading
Loading status checks…
35b8193
@numkem
Copy link
Contributor Author

numkem commented Apr 26, 2020

@DamienCassou this should do it!

@DamienCassou DamienCassou merged commit 9a23aea into NixOS:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numkem @nixos-discourse @DamienCassou @cole-h