Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8055: Fix crash when the road toolbar is open, but the availabil… #8058

Merged
merged 1 commit into from Apr 5, 2020

Conversation

stormcone
Copy link
Contributor

…ity of the current road type has changed.

This patch is only fixes the crash part of the issue.

src/road_gui.cpp Outdated Show resolved Hide resolved
src/road_gui.cpp Outdated Show resolved Hide resolved
src/road_gui.cpp Outdated Show resolved Hide resolved
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Apr 5, 2020
glx22
glx22 previously approved these changes Apr 5, 2020
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commit message may need to be rewritten to include reference to c02ef3e and shortening

…ut the availability of the current road type has changed.
@stormcone
Copy link
Contributor Author

Do you have any suggestions, or could you rewrite it when you merge?

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can be rewritten on merge

@LordAro LordAro merged commit 2514f43 into OpenTTD:master Apr 5, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 13, 2020
LordAro pushed a commit that referenced this pull request Apr 13, 2020
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 26, 2020
@stormcone stormcone deleted the pr-8055 branch August 29, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants