Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comedilib: init at 0.11.0 #84243

Merged
merged 1 commit into from May 24, 2020
Merged

comedilib: init at 0.11.0 #84243

merged 1 commit into from May 24, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 4, 2020

Motivation for this change

Optional dependency for GNUradio (see #82263 ).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor Author

@GrahamcOfBorg eval

@doronbehar
Copy link
Contributor Author

From some reason @GrahamcOfBorg had issues with the attempt to split the outputs - hence all the force-pushes. I removed the outputs = []; line, since it's not too bad if all files will be in $out.

@flokli
Copy link
Contributor

flokli commented May 23, 2020

Do you intend to use lib/python3.7/site-packages/comedi.py for gnuradio?

I noticed it's not contained in find $(nix-build -E "with import <nixpkgs> {};python3.withPackages (_: [comedilib])" -I nixpkgs=$PWD)/lib/ | grep comedilib, so you might need to move things from $out/${python.sitePackages}/* into a separate folder.

@doronbehar
Copy link
Contributor Author

Do you intend to use lib/python3.7/site-packages/comedi.py for gnuradio?

Not really... I just noticed that the build report of it searched for comedilib support and I suspect these is not done via Python but via the c headers.

However, If I do this:

diff --git i/pkgs/top-level/python-packages.nix w/pkgs/top-level/python-packages.nix
index 86339e361cb..efd362b7fc4 100644
--- i/pkgs/top-level/python-packages.nix
+++ w/pkgs/top-level/python-packages.nix
@@ -2005,6 +2005,8 @@ in {
 
   constantly = callPackage ../development/python-modules/constantly { };
 
+  comedilib = toPythonModule pkgs.comedilib;
+
   cornice = callPackage ../development/python-modules/cornice { };
 
   cram = callPackage ../development/python-modules/cram { };

This works:

find $(nix-build -E "with import <nixpkgs> {};python3.withPackages (ps: [ps.comedilib])" -I nixpkgs=$PWD)/lib/ | grep comedi

@doronbehar
Copy link
Contributor Author

Should I do it?

@flokli
Copy link
Contributor

flokli commented May 24, 2020

Should I do it?

Nah, this was mostly a heads-up. I don't really know how comedilib is being used from gnuradio. It should be easy to add if we need it.

@flokli flokli merged commit 9d333b2 into NixOS:master May 24, 2020
@flokli
Copy link
Contributor

flokli commented May 24, 2020

Thanks for the PR!

@doronbehar doronbehar deleted the package-comedilib branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants