Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qt5: support adwaita-dark theme #84242

Merged
merged 1 commit into from Apr 24, 2020
Merged

nixos/qt5: support adwaita-dark theme #84242

merged 1 commit into from Apr 24, 2020
+4 −2

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2020

Motivation for this change

Add support for adwaita-dark theme

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ghost
Copy link
Author

ghost commented Apr 4, 2020

cc @worldofpeace

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 4, 2020
@ghost
Copy link
Author

ghost commented Apr 5, 2020

@matthewbauer Applied, thanks!

@worldofpeace worldofpeace merged commit 90e16f7 into NixOS:master Apr 24, 2020
@worldofpeace
Copy link
Contributor

You'll probably want to port this over to the qt module, if you haven't already.

@ghost
Copy link
Author

ghost commented Apr 24, 2020

@worldofpeace Thanks!

@ghost ghost deleted the qt branch April 24, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @matthewbauer