Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-desktop: add gsettings schemas to the wrapper #84245

Merged
merged 1 commit into from Apr 4, 2020
Merged

riot-desktop: add gsettings schemas to the wrapper #84245

merged 1 commit into from Apr 4, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Apr 4, 2020

Motivation for this change

Fix #83544

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (only riot-desktop)
  • Tested execution of all binary files
  • Tested file picker works
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested review from jtojnar and pacien April 4, 2020 09:30
@ofborg ofborg bot requested a review from worldofpeace April 4, 2020 09:37
pacien
pacien approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; fixes the issue.

It would be nice to backport this fix to release-20.03 as well if possible.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Apr 4, 2020

Thank you for the review. I'm merging it.

@rnhmjoj rnhmjoj merged commit 4540716 into NixOS:master Apr 4, 2020
@rnhmjoj rnhmjoj deleted the riot-fix branch April 7, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

riot-desktop crashes when attempting to attach a file on KDE system
2 participants
@rnhmjoj @pacien