Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nixUnstable + nixFlakes, remove nix1 #84214

Merged
merged 2 commits into from Apr 5, 2020
Merged

Update nixUnstable + nixFlakes, remove nix1 #84214

merged 2 commits into from Apr 5, 2020

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Apr 3, 2020

Motivation for this change

Cleaned up the expression by removing nix1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 4, 2020 •
edited

@GrahamcOfBorg eval

(ofborg was having a sick day please forgive it)

@grahamc
Copy link
Member

grahamc commented Apr 4, 2020

It has a useful error now :)

@cole-h
Copy link
Member

cole-h commented Apr 4, 2020

Hope I'm not being too annoying: most recent eval failure is because you didn't also remove the nix1 attribute from top-level/all-packages.nix. I'd link to the line, but GitHub doesn't load 25k lines; it's line 25446, or thereabouts.

@edolstra
Copy link
Member Author

edolstra commented Apr 4, 2020

@cole-h Thanks, fixed!

@cole-h
Copy link
Member

cole-h commented Apr 4, 2020

nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 84214 results in the following:

[52 built (2 failed), 638 copied (3103.7 MiB), 473.9 MiB DL]
error: build of '/nix/store/cfzyv4f5hmyncazdv1mrl3grpr19i795-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/84214
13 package marked as broken and skipped:
cadaver linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidiabl muslCross nix-delegate nix-deploy nix-exec nix-linter python37Packages.pythonnet python38Packages.libselinux python38Packages.nixpkgs-pytools python38Packages.pythonnet

2 package failed to build:
hydra-unstable python38Packages.nixpkgs

42 package built:
bundix cabal2nix cachix common-updater-scripts crystal2nix dep2nix disnix disnixos fusionInventory go2nix hydra-flakes hydra-migration lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update-source nixFlakes nixUnstable nixos-generators nixui pantheon.nixpkgs-github-update python37Packages.nixpkgs python37Packages.pythonix python38Packages.pythonix vgo2nix vulnix

Maybe a spurious failure on my system? Maybe safe to ignore? I dunno. But I'll leave this here in case it's useful.

hydra-unstable 
builder for '/nix/store/sk2jwac7rk9hgcz9405amiqva5ihh73k-hydra-2020-03-24.drv' failed with exit code 2; last 10 log lines:
  hydra-eval-jobs.cc:158:38: error: base operand of '->' has non-pointer type 'nix::Attr'
    158 |                         auto v = (*a)->value->listElems()[n];
        |                                      ^~
  make[3]: *** [Makefile:440: hydra_eval_jobs-hydra-eval-jobs.o] Error 1
  make[3]: Leaving directory '/build/source/src/hydra-eval-jobs'
  make[2]: *** [Makefile:360: all-recursive] Error 1
  make[2]: Leaving directory '/build/source/src'
  make[1]: *** [Makefile:414: all-recursive] Error 1
  make[1]: Leaving directory '/build/source'
  make: *** [Makefile:344: all] Error 2
python38Packages.nixpkgs 
builder for '/nix/store/avlyyyf7837na96321cd6v5wymnzir9f-python3.8-nixpkgs-0.2.4.drv' failed with exit code 1; last 10 log lines:
      import nix
  ModuleNotFoundError: No module named 'nix'


  ----------------------------------------------------------------------
  Ran 1 test in 0.000s

  FAILED (errors=1)
  Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>

@edolstra
Copy link
Member Author

edolstra commented Apr 5, 2020

Looks like hydra-unstable should be updated (or removed). There are some fixes upstream.

Don't know what python38Packages.nixpkgs is.

@edolstra edolstra merged commit 7121160 into NixOS:master Apr 5, 2020
@edolstra edolstra deleted the update-nix branch April 5, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edolstra @cole-h @grahamc