-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize NT 5.2 Service Pack 2 as supported in the installer #8057
Comments
Any support for Windows XP level Windows API implementation is coincidental, it's not something we aim to run on. None of our core developers have the time to test on operating systems that aren't their primary, so if the installer claimed to support ReactOS but the game by chance uses some API missing and wouldn't run/crashed, we'd never know. A pull request resolving this would be welcome, but I wouldn't expect anyone on the core team to come up with something. |
It's not really about ReactOS even though that's where I noticed the issue. ReactOS itself aims to be and claims to applications that it is compatible with NT 5.2 SP2 (Windows Server 2003, XP x64). although from what I've seen, OpenTTD is fully functional, compatibility breaks are probably on ReactOS's part, not OpenTTD. The main issue here is that the installer recognizes NT 5.1 SP3 (XP 32-bit) as compatible, and while NT 5.2 is a superset of API compatibility from that, the installer creates a warning when running on it. Or maybe all Windows versions prior to some recent one (7?) are just untested and should be "unsupported" by OpenTTD. That would seem fair to me; it might happen to work, but without a guarantee of doing so. |
Yes I should probably have written "anything earlier than Windows 7", I think that's the current intended target. |
We just determine win9x or not using OpenTTD/os/windows/installer/install.nsi Lines 554 to 572 in e7b9014
And with #7270 the installer will be generated by CPack. |
Since CMake is merged, we no longer have a check like this anymore. So for our next release (1.11) this problem is resolved :) |
Version of OpenTTD
1.10.0
Expected result
The installer to run without complaining about minimum operating system version requirements.
Actual result
Installer complains that "You are trying to install [..] on Windows 95, 98, ME, 2000 and XP without SP3.", though it allows continuing past the warning.
Steps to reproduce
Install the game on ReactOS. Presumably this also happens on Windows Server 2003 and Windows XP x64 Edition, though I haven't tested the latter two cases.
The text was updated successfully, but these errors were encountered: