Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: Update generated runtime dependencies #84206

Merged
merged 1 commit into from Apr 4, 2020
Merged

steam: Update generated runtime dependencies #84206

merged 1 commit into from Apr 4, 2020

Conversation

shazow
Copy link
Contributor

@shazow shazow commented Apr 3, 2020

Motivation for this change

nix-shell -p steam was failing on master, with a bunch of errors ending with:

curl: (22) The requested URL returned error: 404
error: cannot download libvulkan1.deb from any mirror
builder for '/nix/store/1sasqspv1qjw95128g72zxys728zpqyv-libvulkan1.deb.drv' failed with exit code 1
Things done

Ran ./update-runtime.py, did the trick!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Apr 4, 2020

Looks good, and runs for me.

@srhb srhb merged commit 8223091 into NixOS:master Apr 4, 2020
@srhb
Copy link
Contributor

srhb commented Apr 4, 2020

Weirdly, no failures in 20.03 steam. Should this be backported anyway?

@shazow
Copy link
Contributor Author

shazow commented Apr 4, 2020

Hm not sure, I've been mostly playing around with master lately due to some upstream work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shazow @srhb