Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.PyGithub: 1.45 -> 1.47 #84257

Merged
merged 1 commit into from Apr 4, 2020
Merged

python3Packages.PyGithub: 1.45 -> 1.47 #84257

merged 1 commit into from Apr 4, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 4, 2020

Upstream dropped python2 support in 1.45, so the nixpkgs-update bot has not
been successful in bumping it.

While this still does not run the test suite, it gets us closer.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
python3Packages.PyGithub: 1.45 -> 1.47
9c7a2c4 
Upstream dropped python2 support in 1.45, so the `nixpkgs-update` bot has not
been successful in bumping it.

While this still does not run the test suite, it gets us closer.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 4, 2020

Result of nixpkgs-review pr 84257 1

4 packages built:
- cligh
- python37Packages.PyGithub
- python38Packages.PyGithub
- sourcehut.dispatchsrht

@bhipple
Copy link
Contributor Author

bhipple commented Apr 4, 2020

^ Above comment was posted with Mic92/nixpkgs-review#93, using PyGithub 1.47, so it appears to work just fine :)

jonringer
jonringer approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 84257 1

4 package built: - cligh - python37Packages.PyGithub - python38Packages.PyGithub - sourcehut.dispatchsrht

@jonringer jonringer merged commit d20a62a into NixOS:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @jonringer