Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-cinnabar: init at 0.5.4 #84247

Merged
merged 1 commit into from Apr 7, 2020
Merged

git-cinnabar: init at 0.5.4 #84247

merged 1 commit into from Apr 7, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Apr 4, 2020 •
edited

git-cinnabar calls into Mercurial as a library, so we make use the
same version of Python as Mercurial.

Support for Python 3 is an experimental feature in git-cinnabar, but
we unconditionally use it here because:

  • Mercurial in Nixpkgs only supports Python 3.
  • git-cinnabar touches a network, and for that purpose it's good to use a version of Python that is going to get security updates.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
gitAndTools.git-cinnabar: init at 0.5.4
5507fa1 
git-cinnabar calls into Mercurial as a library, so we make use the
same version of Python as Mercurial.

Support for Python 3 is an experimental feature in git-cinnabar, but
we unconditionally use it here because:

* Mercurial in Nixpkgs only supports Python 3.
* git-cinnabar touches a network, and for that purpose it's good to
  use a version of Python that is going to get security updates.
Emantor
Emantor approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked license
  • build package
 nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84247/build.nix
[3 built, 30 copied (74.5 MiB), 11.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84247
1 package built:
gitAndTools.git-cinnabar
  • output binaries work as far as outputting help text, found no quick way to check against a real repository

@alyssais alyssais merged commit fafac02 into NixOS:master Apr 7, 2020
@alyssais alyssais deleted the git-cinnabar branch April 7, 2020 09:07
@alyssais
Copy link
Member Author

alyssais commented Apr 7, 2020

Thanks for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @Emantor