Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.persistent-postgresql: don't check #84272

Merged
merged 1 commit into from Apr 5, 2020
Merged

haskellPackages.persistent-postgresql: don't check #84272

merged 1 commit into from Apr 5, 2020

Conversation

turboMaCk
Copy link
Member

Disable tests for persistent-postgresql. Test suite now requires database.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kubaracek
Copy link
Contributor

kubaracek commented Apr 4, 2020 •
edited

Had problem with this (that persistent-postgresql is running tests against an actual local database) 👍

@cdepillabout
Copy link
Member

@turboMaCk persistent-postgresql is marked broken. Can you mark it unbroken?

https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968

This appears to build though, so it is fine to merge in after being marked unbroken.

@turboMaCk
Copy link
Member Author

@cdepillabout are you sure it's marked as broken? I admit I had allowBroken = true in config before but after removing it this package seems to build. Also I don't see it in broken section of configuration-hackage2nix.yaml. Can you please check this again?

@cdepillabout
Copy link
Member

@turboMaCk Unless I'm doing something wrong, I believe it is:

$ hub checkout https://github.com/NixOS/nixpkgs/pull/84272
From github.com:NixOS/nixpkgs
 * [new ref]                 refs/pull/84272/head -> persistent-postgresql
Switched to branch 'persistent-postgresql'
$ nix-build -A haskellPackages.persistent-postgresql
error: Package ‘persistent-postgresql-2.10.1.2’ in pkgs/development/haskell-modules/hackage-packages.nix:186837 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use '--show-trace' to show detailed location information)
$ git grep persistent-postgresql
...
pkgs/development/haskell-modules/configuration-hackage2nix.yaml:  - persistent-postgresql

@turboMaCk
haskellPackages.persistent-postgresql: don't check
69996c8 
Test suite requires database. Disabling tests as is done for mysql backend.
@turboMaCk
Copy link
Member Author

turboMaCk commented Apr 5, 2020 •
edited

You're right sorry. Not sure why I missed it few moments ago. IRemoving allowBroken did not work for me because I had it already cached in nix-store on my machine but I must have missed the line in yaml.

cdepillabout
cdepillabout reviewed Apr 5, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
@@ -1474,7 +1474,9 @@ self: super: {
vty = self.vty_5_28_2;
});

# Test suite requires database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this comment as well

@cdepillabout cdepillabout merged commit b0caf86 into NixOS:haskell-updates Apr 5, 2020
@cdepillabout
Copy link
Member

Looks good, thanks!

@turboMaCk turboMaCk deleted the persistent-postgresql branch April 5, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turboMaCk @kubaracek @cdepillabout