Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libturbojpeg: init at 2.0.4 #84269

Closed
wants to merge 1 commit into from
Closed

libturbojpeg: init at 2.0.4 #84269

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Init libturbojpeg at current stable release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

I've built other nixpkgs software that use this as a buildInput as well.

cole-h
cole-h reviewed Apr 4, 2020
View reviewed changes
pkgs/development/libraries/libturbojpeg/default.nix Outdated
meta = with stdenv.lib; {
description = "libjpeg-turbo is a JPEG image codec that uses SIMD instructions (MMX, SSE2, AVX2, NEON, AltiVec) to accelerate baseline JPEG compression and decompression on x86, x86-64, ARM, and PowerPC systems, as well as progressive JPEG compression on x86 and x86-64 systems.";
inherit (src.meta) homepage;
license = [ licenses.ijg license.bsd3 license.zlib ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = [ licenses.ijg license.bsd3 license.zlib ];
license = [ licenses.ijg licenses.bsd3 licenses.zlib ];

2 characters short of a successful eval :P

@pbogdan
Copy link
Member

pbogdan commented Apr 4, 2020

Pardon my ignorance - isn't this the same as the existing libjpeg_turbo package?

@colemickens
Copy link
Member Author

Looks like it. Thanks @pbogdan. Thanks @cole-h for the review.

@colemickens colemickens closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colemickens @pbogdan @cole-h