Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pint: 0.9 -> 0.11 #84197

Merged
merged 2 commits into from Apr 3, 2020
Merged

pythonPackages.pint: 0.9 -> 0.11 #84197

merged 2 commits into from Apr 3, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Bump pythonPackages.pint version. Also fixes build issue on Hydra: https://hydra.nixos.org/build/115315938.

Will backport to [20.03].

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc April 3, 2020 16:36
@drewrisinger
Copy link
Contributor Author

ping @NixOS/nixos-release-managers
@GrahamcOfBorg build python37Packages.pint python38Packages.pint
Currently failing to build datasette, update coming. python27 build is disabled by the source in this version.

@drewrisinger
Copy link
Contributor Author

datasette was failing to build. Should build now.
@GrahamcOfBorg build python37Packages.pint python38Packages.pint datasette

bhipple
bhipple approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 84197 1

3 package built: - datasette (python37Packages.datasette) - python37Packages.pint - python38Packages.pint

@bhipple bhipple merged commit f6b382b into NixOS:master Apr 3, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-pint branch April 3, 2020 22:05
@drewrisinger drewrisinger mentioned this pull request Apr 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @bhipple