Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babashka: 0.0.71 -> 0.0.78 #84284

Merged
merged 1 commit into from Apr 5, 2020
Merged

babashka: 0.0.71 -> 0.0.78 #84284

merged 1 commit into from Apr 5, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 4, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jlesquembre April 4, 2020 21:31
@AndersonTorres
Copy link
Member Author

#83776

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Apr 4, 2020 •
edited

@bhougland18
@BAndresen
@DerGuteMoritz
@mmilata

four-in-one ping

bennyandresen
bennyandresen reviewed Apr 4, 2020
View reviewed changes
Copy link
Contributor

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also to your question: To build clojure tools from source we would have to chase a ton of clojure/java dependencies down and package them up for nix first or accept that the package can't be built in sandbox mode.
Using the prepared uberjar is the pragmatic choice.

@AndersonTorres AndersonTorres mentioned this pull request Apr 5, 2020
Closed
10 tasks
@AndersonTorres AndersonTorres merged commit f0959a7 into NixOS:master Apr 5, 2020
@AndersonTorres AndersonTorres deleted the update-babashka branch April 5, 2020 01:27
@AndersonTorres
Copy link
Member Author

Maybe some day when he have something like "javaStdenv"...

@bhougland18 bhougland18 mentioned this pull request Apr 5, 2020
Closed
10 tasks
@jlesquembre
Copy link
Member

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyandresen bennyandresen bennyandresen left review comments

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @jlesquembre @bennyandresen